refactor: introduce helpers and types #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
changed the base branch from
gio/refactor-bundle-notifier
to
main
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 414 417 +3
Lines 35002 35084 +82
=======================================
+ Hits 34127 34209 +82
Misses 875 875
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 97.50% 97.53% +0.03%
==========================================
Files 414 420 +6
Lines 35002 35234 +232
==========================================
+ Hits 34127 34364 +237
+ Misses 875 870 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 97.50% 97.53% +0.03%
==========================================
Files 414 420 +6
Lines 35002 35234 +232
==========================================
+ Hits 34127 34364 +237
+ Misses 875 870 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 97.55% 97.58% +0.03%
==========================================
Files 449 455 +6
Lines 36208 36701 +493
==========================================
+ Hits 35321 35813 +492
- Misses 887 888 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/helpers
branch
from
0909a53
to
d335c05
Compare
joseph-sentry
approved these changes
Jul 31, 2024
Part 1 of the bundle analysis notify refactor. This PR simply introduces `NotificationType` and helper functions to determine what notifications are configured based on the current_yaml. Some other helper functions are from the existing notify service slightly adjusted to not depend on the class they are declared in
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/helpers
branch
from
d335c05
to
a22bdab
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the bundle analysis notify refactor.
This PR simply introduces
NotificationTypeand helper functions to determinewhat notifications are configured based on the current_yaml.
Some other helper functions are from the existing notify service slightly adjusted
to not depend on the class they are declared in