Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid Escape Sequence on Cobertura parser #575

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Jul 29, 2024

Fixes invalid escape sequence...

Related logs: https://console.cloud.google.com/logs/query;query=severity%3DERROR%0A%22worker%2Fservices%2Freport%2Flanguages%2Fcobertura.py%22;pinnedLogId=2024-04-08T19:18:39.852000850Z%2Fgt0cscxqclw9v94d;summaryFields=jsonPayload%252Fusername:false:32:beginning;cursorTimestamp=2024-07-29T22:46:07.456996759Z;duration=P1D?project=genuine-polymer-165712&authuser=1&rapt=AEjHL4M3xuoV-WET7swbpc94gTPEq8p_N0PpuZcCeMOHTb153SKBFmDHhEwYcsqLEueQ06MpwogKmAbmC2EUok6nmXE0zZAHzZQ1RAngRlWdyp8_FqIvqZI

Roughly ~6k instances a day since who knows when

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34986    34986           
=======================================
  Hits        34109    34109           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)
Files Coverage Δ
services/report/languages/cobertura.py 96.22% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (2a6cb28) to head (602eca9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34986    34986           
=======================================
  Hits        34109    34109           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)
Files Coverage Δ
services/report/languages/cobertura.py 96.22% <ø> (ø)

Copy link

codecov-public-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (2a6cb28) to head (602eca9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34986    34986           
=======================================
  Hits        34109    34109           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)
Files Coverage Δ
services/report/languages/cobertura.py 96.22% <ø> (ø)

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (2a6cb28) to head (602eca9).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         449      449           
  Lines       36192    36192           
=======================================
  Hits        35303    35303           
  Misses        889      889           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.64% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)
Files Coverage Δ
services/report/languages/cobertura.py 96.22% <ø> (ø)

This change has been scanned for critical changes. Learn more

@ajay-sentry ajay-sentry changed the title try and fix fix: Invalid Escape Sequence on Cobertura parser Jul 30, 2024
@ajay-sentry ajay-sentry added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit ed134ad Jul 30, 2024
29 of 30 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/fix-invalid-escape branch July 30, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants