Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make newfiles part of files behaviour #573

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat: make newfiles part of files behaviour #573

merged 3 commits into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. feat: make newfiles part of files behaviour 

    If a user specifies the files formatting in their comment layout
config, we want it to show the newfiles formatting as well.
    @joseph-sentry
    joseph-sentry committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    40c6d48 View commit details
    Browse the repository at this point in the history

  2. fix: newfiles and files behaviour 

    this commit fixes a previously erroneous commit that attempted to
make it so if "files" or "tree" are mentioned in the comment layout
config then the condensed_files section is also included.

We want the behaviour if "files" is selected in the config to be:
1. always show the files section
2 if there are missing lines in the path then also show the
condensed_files section
    @joseph-sentry
    joseph-sentry committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    94b2cf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. fix: remove unnecessary enumerate

    @joseph-sentry
    joseph-sentry committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    69639d9 View commit details
    Browse the repository at this point in the history