Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchain to latest stable, using the minimal profile #571

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Swatinem
Copy link
Contributor

If I am not mistaken, test-results-parser is the only Rust package that is built from source, as codecov-ribs is consumed as a prebuilt binary from PyPI.
As test-results-parser does not use any nightly features, this switches to the latest stable instead of pulling in an outdated nightly.

Using the minimal profile here means that clippy, rustfmt or other tools are not being installed, speedings things up slightly.


Going forward, I would recommend also consuming test-results-parser via prebuilt packages, in which case no Rust compiler would be needed in this docker image at all.

If I am not mistaken, `test-results-parser` is the only Rust package that is built from source, as `codecov-ribs` is consumed as a prebuilt binary from PyPI.
As `test-results-parser` does not use any nightly features, this switches to the latest `stable` instead of pulling in an outdated nightly.
@Swatinem Swatinem self-assigned this Jul 23, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34982           
=======================================
  Hits        34105    34105           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (555a769) to head (d2f0cb6).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34982           
=======================================
  Hits        34105    34105           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)

Copy link

codecov-public-qa bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (555a769) to head (d2f0cb6).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         414      414           
  Lines       34982    34982           
=======================================
  Hits        34105    34105           
  Misses        877      877           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (555a769) to head (d2f0cb6).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         449      449           
  Lines       36188    36188           
=======================================
  Hits        35299    35299           
  Misses        889      889           
Flag Coverage Δ
integration 97.49% <ø> (ø)
latest-uploader-overall 97.49% <ø> (ø)
unit 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <ø> (ø)
OutsideTasks 97.70% <ø> (ø)

This change has been scanned for critical changes. Learn more

@Swatinem Swatinem added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 02be991 Jul 31, 2024
30 checks passed
@Swatinem Swatinem deleted the swatinem/update-rust branch July 31, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants