Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user of errors with uploading in comment #570

Merged
merged 7 commits into from
Jul 31, 2024

fix: make notify error opt in using codecov.yml

a73ff80
Select commit
Loading
Failed to load commit list.
Merged

Notify user of errors with uploading in comment #570

fix: make notify error opt in using codecov.yml
a73ff80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2024 in 0s

97.61% (+0.06%) compared to 555a769

View this Pull Request on Codecov

97.61% (+0.06%) compared to 555a769

Details

Codecov Report

Attention: Patch coverage is 99.24528% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.61%. Comparing base (555a769) to head (a73ff80).
Report is 5 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files Patch % Lines
helpers/notifier.py 97.67% 1 Missing ⚠️
services/test_results.py 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   97.54%   97.61%   +0.06%     
==========================================
  Files         449      452       +3     
  Lines       36188    37160     +972     
==========================================
+ Hits        35299    36272     +973     
+ Misses        889      888       -1     
Components Coverage Δ
NonTestCode 94.69% <98.76%> (+0.05%) ⬆️
OutsideTasks 97.74% <97.75%> (+0.03%) ⬆️
Files Coverage Δ
celery_config.py 70.51% <100.00%> (+0.38%) ⬆️
helpers/checkpoint_logger/flows.py 100.00% <100.00%> (ø)
services/tests/test_test_results.py 100.00% <100.00%> (ø)
tasks/__init__.py 100.00% <100.00%> (ø)
tasks/notify_error.py 100.00% <100.00%> (ø)
tasks/test_results_finisher.py 97.85% <100.00%> (+0.11%) ⬆️
tasks/tests/unit/test_notify_error_task.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <100.00%> (ø)
tasks/upload_finisher.py 72.90% <100.00%> (+2.16%) ⬆️
... and 2 more

... and 7 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.UploadFinisher
run/app.tasks.test_results.TestResultsFinisherTask