Add db_session to ActivateAccountUserTask #563
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35495 +7
=======================================
+ Hits 34608 34615 +7
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35495 +7
=======================================
+ Hits 34608 34615 +7
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35495 +7
=======================================
+ Hits 34608 34615 +7
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This field is needed to `run_impl` properly. See Sentry error: https://codecov.sentry.io/share/issue/62a996975a424922b6ceb9d0d1b91e47/
michelletran-codecov
force-pushed
the
fix_account_user_bug
branch
from
ef8069f
to
249e227
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 458 458
Lines 36560 36567 +7
=======================================
+ Hits 35666 35673 +7
Misses 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
| @@ -12,6 +13,7 @@ | |||
| class ActivateAccountUserTask(BaseCodecovTask, name=activate_account_user_task_name): | |||
| def run_impl( | |||
| self, | |||
| _db_session: Session, | |||
There was a problem hiding this comment.
Potentially dumb question, but does adding a session in any way affect any transaction related things? Like will the BaseCodecovTask use the session in any way that could silently interfere with anything within the task?
There was a problem hiding this comment.
Not a dumb question! I don't think it will affect the transaction because the session is created but isn't used. So there's nothing in an uncommitted transaction to cause issues. AFAICT, the ProcessFlakesTask also creates a session without using it, and there hasn't been any trouble with Django DB access.
There was a problem hiding this comment.
Cool cool, yeah that makes sense, even if it were to commit something in the parent class, there's nothing in this task itself that's using the session itself
This field is needed to
run_implproperly. See Sentry error: https://codecov.sentry.io/share/issue/62a996975a424922b6ceb9d0d1b91e47/Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.