fix: empty reports not being saved in readable format #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 423 423
Lines 35417 35419 +2
=======================================
+ Hits 34537 34539 +2
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 423 423
Lines 35417 35419 +2
=======================================
+ Hits 34537 34539 +2
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 423 423
Lines 35417 35419 +2
=======================================
+ Hits 34537 34539 +2
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 97.54% 97.55%
=======================================
Files 456 456
Lines 36489 36491 +2
=======================================
+ Hits 35595 35597 +2
Misses 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Apparently I forgot a little detail in the previous "fix" (that the ProcessingResult is broken apart if it fails) This time I tested locally 😅
giovanni-guidini
force-pushed
the
gio/rewrite-empty-reports
branch
from
ea0ae23
to
47a7bf5
Compare
nora-codecov
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I forgot a little detail in the previous "fix"
(that the ProcessingResult is broken apart if it fails)
This time I tested locally 😅