refactor: break up bundle analysis services #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add nothing. It's a simple refactor breaking up different services related to bundle analysis into different files. The "bundle_analysis" service is already a grouping of different things (processing, comparison, notify, etc) and it's getting big as is.
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 97.53% 97.54% +0.01%
==========================================
Files 451 456 +5
Lines 36119 36489 +370
==========================================
+ Hits 35229 35595 +366
- Misses 890 894 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 423 +3
Lines 35397 35417 +20
=======================================
+ Hits 34517 34537 +20
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 423 +3
Lines 35397 35417 +20
=======================================
+ Hits 34517 34537 +20
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 423 +3
Lines 35397 35417 +20
=======================================
+ Hits 34517 34537 +20
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add nothing. It's a simple refactor breaking up
different services related to bundle analysis into different files.
The "bundle_analysis" service is already a grouping of different things
(processing, comparison, notify, etc) and it's getting big as is.