repository secret was being saved to repo when the update failed #557
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 451 451
Lines 36111 36129 +18
=======================================
+ Hits 35221 35239 +18
Misses 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35389 35407 +18
=======================================
+ Hits 34509 34527 +18
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35389 35407 +18
=======================================
+ Hits 34509 34527 +18
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35389 35407 +18
=======================================
+ Hits 34509 34527 +18
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -991,13 +991,15 @@ def possibly_setup_webhooks(self, commit, repository_service): | |||
| ) | |||
| repository.hookid = hookid | |||
| repo_data["repo"]["hookid"] = hookid | |||
| repository.webhook_secret = webhook_secret | |||
There was a problem hiding this comment.
So we save the webhook if should_post_webhook or before?
There was a problem hiding this comment.
yes, only add the webhook_secret to the repository if the create_webhook or webhook_update update goes through without error
fixes an issue from #521