-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update zipp version #554
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 414 414
Lines 34982 34982
=======================================
Hits 34105 34105
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 449 449
Lines 36188 36188
=======================================
Hits 35299 35299
Misses 889 889
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm being annoying, but could you try the suggestions please? 🙏
I'm just trying to avoid having more explicit dependencies than needed
requirements.in
Outdated
openai | ||
zipp>=3.19.1 | ||
certifi>=2024.07.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you merge codecov/shared#286 and update shared then certify will be fixed here too
requirements.in
Outdated
openai | ||
zipp>=3.19.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to update opentelemetry-instrumentation-celery
(has a new version 0.46b0) and / or opentelemetry-sdk
(has a new version 1.25.0) to see if that fixes the zipp issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I tested this and it's not enough. zipp
won't automatically upgrade if you update any of those 2.
However if you run the command below it does upgrade in the requirements.txt
file without having to explicitly require it :E
$ pip-compile requirements.in --upgrade-package zipp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did not know about that command, very useful for this kind of task
7c5e113
to
4f5105a
Compare
fixes: https://github.com/codecov/internal-issues/issues/588