feat: add flaky shadow mode #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35497 +9
=======================================
+ Hits 34608 34617 +9
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35497 +9
=======================================
+ Hits 34608 34617 +9
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 425 425
Lines 35488 35497 +9
=======================================
+ Hits 34608 34617 +9
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 458 458
Lines 36560 36569 +9
=======================================
+ Hits 35666 35675 +9
Misses 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
we want to run the write part of the flake detection process without doing the read part of the flake detection process
joseph-sentry
force-pushed
the
joseph/flake-shadow-mode
branch
from
b52eb6f
to
1e4d125
Compare
michelletran-codecov
approved these changes
Jul 17, 2024
tasks/sync_pull.py
Outdated
Comment on lines
435
to
440
| if ( | ||
| FLAKY_TEST_DETECTION.check_value(identifier=repoid, default=False) | ||
| and read_yaml_field( | ||
| current_yaml, ("test_analytics", "flake_detection"), False | ||
| ) | ||
| ) or (FLAKY_SHADOW_MODE.check_value(identifier=repoid, default=False)): |
There was a problem hiding this comment.
This if statement is kind of hard to read. I would suggest pulling up the conditional into a variable or function. If you pull it up into a function, we can even make this reusable in test_results_finisher.py.
There was a problem hiding this comment.
addressed 👍
Signed-off-by: joseph-sentry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to run the write part of the flake detection process without doing the read part of the flake detection process