dev: Add Ruff Perf rules to worker #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35411 35389 -22
=======================================
- Hits 34530 34509 -21
+ Misses 881 880 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35411 35389 -22
=======================================
- Hits 34530 34509 -21
+ Misses 881 880 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 420 420
Lines 35411 35389 -22
=======================================
- Hits 34530 34509 -21
+ Misses 881 880 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 451 451
Lines 36133 36111 -22
=======================================
- Hits 35242 35221 -21
+ Misses 891 890 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adrian-codecov
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Part of the lint enhancement epic, this PR aims to add the Perflint PERF rules, with the fixes majorly being around creating list comprehensions or using .keys() or .values() instead of .items() for dictionaries
These can be found here:
Links to relevant tickets
Closes codecov/engineering-team#2050
What does this PR do?
This PR adds the rules listed above and fixes any errors that stemmed from them.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.