Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect param name in github webhook check task #551

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Jul 9, 2024

saw this spewing in my local instance

the correct param name is installation_id

installation_id: int = None,

@matt-codecov matt-codecov requested a review from a team July 9, 2024 00:09
@codecov-qa
Copy link

codecov-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (562a878) to head (9dedcd2).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35411    35411           
=======================================
  Hits        34530    34530           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <ø> (ø)
latest-uploader-overall 97.51% <ø> (ø)
unit 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
tasks/github_app_webhooks_check.py 100.00% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35411    35411           
=======================================
  Hits        34530    34530           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <ø> (ø)
latest-uploader-overall 97.51% <ø> (ø)
unit 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
tasks/github_app_webhooks_check.py 100.00% <ø> (ø)

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (562a878) to head (9dedcd2).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         451      451           
  Lines       36133    36133           
=======================================
  Hits        35242    35242           
  Misses        891      891           
Flag Coverage Δ
integration 97.51% <ø> (ø)
latest-uploader-overall 97.51% <ø> (ø)
unit 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
tasks/github_app_webhooks_check.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link

codecov-public-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (562a878) to head (9dedcd2).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         420      420           
  Lines       35411    35411           
=======================================
  Hits        34530    34530           
  Misses        881      881           
Flag Coverage Δ
integration 97.51% <ø> (ø)
latest-uploader-overall 97.51% <ø> (ø)
unit 97.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
tasks/github_app_webhooks_check.py 100.00% <ø> (ø)

@matt-codecov matt-codecov added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2024
@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 8760df2 Jul 16, 2024
29 of 30 checks passed
@giovanni-guidini giovanni-guidini deleted the pr551 branch July 16, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants