chore: end sync_pull experiment #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 97.53% 97.53% -0.01%
==========================================
Files 451 451
Lines 36111 36101 -10
==========================================
- Hits 35221 35211 -10
Misses 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35389 35379 -10
==========================================
- Hits 34509 34499 -10
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35389 35379 -10
==========================================
- Hits 34509 34499 -10
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 420 420
Lines 35389 35379 -10
==========================================
- Hits 34509 34499 -10
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
read more on the experiment: https://l.codecov.dev/KvKfel (codecov internal) Ending the pull_sync experiment. The conclusion is to reduce blocking timeout to 0.5s (10x smaller). This apparently can reduce up to 10% of the tasks run. The vast majority of tasks wait less than 100ms for the lock, so there's still plenty room for delays.
giovanni-guidini
force-pushed
the
gio/update-sync-pull-timeout
branch
from
25ce443
to
0e070a1
Compare
joseph-sentry
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read more on the experiment: https://l.codecov.dev/KvKfel (codecov internal)
Ending the pull_sync experiment.
The conclusion is to reduce blocking timeout to 0.5s (10x smaller). This apparently can reduce up to 10% of the tasks run.
The vast majority of tasks wait less than 100ms for the lock, so there's still plenty room for delays.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.