Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix and enable flaky test detection #539

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry marked this pull request as ready for review July 3, 2024 20:31
@joseph-sentry joseph-sentry requested a review from a team July 3, 2024 20:31
@codecov-staging
Copy link

codecov-staging bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         420      420           
  Lines       35320    35326    +6     
=======================================
+ Hits        34440    34446    +6     
  Misses        880      880           
Flag Coverage Δ
integration 97.50% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <100.00%> (+<0.01%) ⬆️
unit 97.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (ø)
OutsideTasks 97.75% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.87% <100.00%> (ø)
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (a920fba) to head (fe69574).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         420      420           
  Lines       35320    35326    +6     
=======================================
+ Hits        34440    34446    +6     
  Misses        880      880           
Flag Coverage Δ
integration 97.50% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <100.00%> (+<0.01%) ⬆️
unit 97.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (ø)
OutsideTasks 97.75% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.87% <100.00%> (ø)
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (a920fba) to head (fe69574).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         420      420           
  Lines       35320    35326    +6     
=======================================
+ Hits        34440    34446    +6     
  Misses        880      880           
Flag Coverage Δ
integration 97.50% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <100.00%> (+<0.01%) ⬆️
unit 97.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (ø)
OutsideTasks 97.75% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.87% <100.00%> (ø)
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (a920fba) to head (fe69574).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         451      451           
  Lines       36043    36049    +6     
=======================================
+ Hits        35153    35159    +6     
  Misses        890      890           
Flag Coverage Δ
integration 97.50% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <100.00%> (+<0.01%) ⬆️
unit 97.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.63% <100.00%> (ø)
OutsideTasks 97.75% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 98.87% <100.00%> (ø)
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 2eea181 Jul 4, 2024
29 of 30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-flakes branch July 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants