Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't select suspended apps #534

Merged
merged 4 commits into from
Jul 4, 2024
Merged

feat: don't select suspended apps #534

merged 4 commits into from
Jul 4, 2024

Commits on Jun 28, 2024

  1. feat: track suspended apps 

    This column is part of the model since codecov/shared#237
but was not reflected in the worker yet.

related: codecov/internal-issues#519
    @giovanni-guidini
    giovanni-guidini committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    840be1a View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' into gio/track-suspended

    @giovanni-guidini
    giovanni-guidini committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6e8ae14 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. feat: don't select suspended apps 

    Currently we ignore if an app is suspended or not.
An app is suspended by the user.
If we select a suspended app we will fail to get an access_token for it
and eventually fail with `InstallationError`

These changes filter out suspended apps from being selected.
In case all apps for the user are suspended we skip notifications.
Other tasks would fail with `NoConfiguredAppsAvailable`.

closes codecov/internal-issues#519
    @giovanni-guidini
    giovanni-guidini committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fcc0563 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. address feedback

    @giovanni-guidini
    giovanni-guidini committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    dc66506 View commit details
    Browse the repository at this point in the history