add True as default for wait_for_ci

[nora-codecov]

The way it is written, if wait_for_ci is not supplied, it evaluates as False-y

per our docs, wait_for_ci default is True

This changes the evaluation, so if wait_for_ci is not supplied, it evaluates to True which follows our intended behavior.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (eb83557) to head (73b4988).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         449      449           
  Lines       35739    35739           
=======================================
  Hits        34848    34848           
  Misses        891      891           

Flag	Coverage Δ
integration	97.48% <ø> (ø)
latest-uploader-overall	97.48% <ø> (ø)
unit	97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	94.58% <ø> (ø)
OutsideTasks	97.74% <ø> (ø)

Files	Coverage Δ
tasks/notify.py Critical	98.25% <ø> (ø)

This change has been scanned for critical changes. Learn more

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (eb83557) to head (73b4988).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           

Flag	Coverage Δ
integration	97.48% <ø> (ø)
latest-uploader-overall	97.48% <ø> (ø)
unit	97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	94.53% <ø> (ø)
OutsideTasks	97.74% <ø> (ø)

Files	Coverage Δ
tasks/notify.py	98.25% <ø> (ø)

[codecov-public-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (eb83557) to head (73b4988).

✅ All tests successful. No failed tests found ☺️

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           

Flag	Coverage Δ
integration	97.48% <ø> (ø)
latest-uploader-overall	97.48% <ø> (ø)
unit	97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	94.53% <ø> (ø)
OutsideTasks	97.74% <ø> (ø)

Files	Coverage Δ
tasks/notify.py	98.25% <ø> (ø)

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           

Flag	Coverage Δ
integration	97.48% <ø> (ø)
latest-uploader-overall	97.48% <ø> (ø)
unit	97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	94.53% <ø> (ø)
OutsideTasks	97.74% <ø> (ø)

Files	Coverage Δ
tasks/notify.py	98.25% <ø> (ø)

[drazisil-codecov]

Fixes codecov/feedback#440

[drazisil-codecov]

@nora-codecov Was this one supposed to close?

[nora-codecov]

@drazisil-codecov fluke with merge queue - sus 🤨
I'm retrying the merge