Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide project coverage #53

Merged
merged 2 commits into from
Aug 10, 2023
Merged

hide project coverage #53

merged 2 commits into from
Aug 10, 2023

Conversation

dana-yaish
Copy link
Contributor

@dana-yaish dana-yaish commented Aug 9, 2023

This PR reads the value of hide_project_coverage yaml value, and adds the block when the value is true, which yields only the patch coverage

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #53 (e880851) into main (2866a1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files         357      357           
  Lines       25917    25942   +25     
=======================================
+ Hits        25558    25583   +25     
  Misses        359      359           
Flag Coverage Δ
integration 98.58% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.58% <100.00%> (+<0.01%) ⬆️
onlysomelabels 98.61% <100.00%> (+<0.01%) ⬆️
unit 98.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.36% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.35% <100.00%> (+<0.01%) ⬆️
Files Changed Coverage Δ
.../notification/notifiers/mixins/message/sections.py 99.63% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

@dana-yaish dana-yaish merged commit da02456 into main Aug 10, 2023
12 checks passed
@dana-yaish dana-yaish deleted the dana/hide-project-cov branch August 10, 2023 11:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR comment capable of not displaying project coverage
2 participants