Add message for users to install Codecov app if they're using public commenter #516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 418 418
Lines 34973 35006 +33
==========================================
+ Hits 34093 34125 +32
- Misses 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 418 418
Lines 34973 35006 +33
==========================================
+ Hits 34093 34125 +32
- Misses 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 418 418
Lines 34973 35006 +33
==========================================
+ Hits 34093 34125 +32
- Misses 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 449 449
Lines 35696 35729 +33
==========================================
+ Hits 34806 34838 +32
- Misses 890 891 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
michelletran-codecov
force-pushed
the
1833_encourage_users_to_install
branch
from
ccd5b24
to
08631bd
Compare
tasks/notify.py
Outdated
| commenter_bot_token = get_config(repository_service.service, "bots", "comment") | ||
| return ( | ||
| repository_service.service == "github" | ||
| and repository_service.data.get("installation") is None | ||
| and repository_service.get_token_by_type(TokenType.comment) | ||
| == commenter_bot_token |
There was a problem hiding this comment.
I'm not 100% sure about this part. Am I missing some checks to make sure that the user doesn't have any installations and is also using the commenter bot?
There was a problem hiding this comment.
This looks OK
Maybe just for peace of mind you should add 1 extra check commenter_bot_token is not None to make sure something is configured for the commenter bot...
| mocker, | ||
| ): | ||
| comparison = sample_comparison | ||
| mocker.patch.object( |
There was a problem hiding this comment.
This might be unecessary in this test if you only care for the 1st line of the comment
tasks/notify.py
Outdated
| commenter_bot_token = get_config(repository_service.service, "bots", "comment") | ||
| return ( | ||
| repository_service.service == "github" | ||
| and repository_service.data.get("installation") is None | ||
| and repository_service.get_token_by_type(TokenType.comment) | ||
| == commenter_bot_token |
There was a problem hiding this comment.
This looks OK
Maybe just for peace of mind you should add 1 extra check commenter_bot_token is not None to make sure something is configured for the commenter bot...
michelletran-codecov
force-pushed
the
1833_encourage_users_to_install
branch
from
08631bd
to
76df4a0
Compare
michelletran-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
…commenter This is to drive more adoption for the Codecov App.
michelletran-codecov
force-pushed
the
1833_encourage_users_to_install
branch
from
76df4a0
to
8d96a88
Compare
This adds a message when we detect that
The idea is to drive more adoption for the Codecov App.
Issue link: codecov/engineering-team#1833
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.