chore: update sync_pull experiment #507
Conversation
This changes the `sync_pull_task_time_to_get_lock_seconds` from "distribution" to "gauge". Turns out distributions only let you aggregate by average, min and max. I want quantiles. Also adds a new metric `sync_pull_task_rejected_count` to count how many tasks DONT run per wait period. After all the goal if this experiment is to see if the reduced wait time is effective in reducing the number of tasks that run
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 417 417
Lines 34796 34811 +15
=======================================
+ Hits 33913 33931 +18
+ Misses 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 417 417
Lines 34796 34811 +15
=======================================
+ Hits 33913 33931 +18
+ Misses 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 417 417
Lines 34796 34811 +15
=======================================
+ Hits 33913 33931 +18
+ Misses 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 97.48% 97.51% +0.02%
==========================================
Files 448 448
Lines 35525 35916 +391
==========================================
+ Hits 34632 35023 +391
Misses 893 893
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes
|
|
According to the Sentry documentation, gauges don't give percentiles and that distributions should. I did take a look at the metric on Sentry and was unable to see the |
After the Sentry metrics disappointed in producing quantiles we are switching to prometheus. The query language is hard, but we know that it can be done. I basically copied the code from `tasks.base` and modified it. I also re-wired the experiment so that we can have more feature flags in there (if wanted)
This changes the
sync_pull_task_time_to_get_lock_secondsfrom "distribution" to "gauge".Turns out distributions only let you aggregate by average, min and max. I want quantiles.
Also adds a new metric
sync_pull_task_rejected_countto count how many tasks DONT runper wait period. After all the goal if this experiment is to see if the reduced wait time
is effective in reducing the number of tasks that run
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.