Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small cleanup #506

Merged
merged 1 commit into from
Jun 19, 2024
Merged

small cleanup #506

merged 1 commit into from
Jun 19, 2024

Conversation

giovanni-guidini
Copy link
Contributor

No description provided.

@@ -341,9 +342,6 @@ def run_impl_within_lock(
)
else:
base_report = None
head_report = report_service.get_existing_report_for_commit(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens on line 300 as well. I'm just removing the repeated operation.

@giovanni-guidini giovanni-guidini requested a review from a team June 19, 2024 10:56
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files         416      417    +1     
  Lines       34759    34795   +36     
=======================================
+ Hits        33876    33912   +36     
  Misses        883      883           
Flag Coverage Δ
integration 97.46% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.46% <100.00%> (+<0.01%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.47% <100.00%> (+0.01%) ⬆️
OutsideTasks 97.73% <ø> (+<0.01%) ⬆️
Files Coverage Δ
tasks/notify.py 98.22% <100.00%> (-0.01%) ⬇️

... and 8 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (af9d841) to head (de0224e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files         416      417    +1     
  Lines       34759    34795   +36     
=======================================
+ Hits        33876    33912   +36     
  Misses        883      883           
Flag Coverage Δ
integration 97.46% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.46% <100.00%> (+<0.01%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.47% <100.00%> (+0.01%) ⬆️
OutsideTasks 97.73% <ø> (+<0.01%) ⬆️
Files Coverage Δ
tasks/notify.py 98.22% <100.00%> (-0.01%) ⬇️

... and 8 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (af9d841) to head (de0224e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files         416      417    +1     
  Lines       34759    34795   +36     
=======================================
+ Hits        33876    33912   +36     
  Misses        883      883           
Flag Coverage Δ
integration 97.46% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.46% <100.00%> (+<0.01%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.47% <100.00%> (+0.01%) ⬆️
OutsideTasks 97.73% <ø> (+<0.01%) ⬆️
Files Coverage Δ
tasks/notify.py 98.22% <100.00%> (-0.01%) ⬇️

... and 8 files with indirect coverage changes

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (af9d841) to head (de0224e).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   97.48%   97.55%   +0.07%     
==========================================
  Files         447      448       +1     
  Lines       35488    36660    +1172     
==========================================
+ Hits        34595    35764    +1169     
- Misses        893      896       +3     
Flag Coverage Δ
integration 97.46% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.46% <100.00%> (+<0.01%) ⬆️
unit 97.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.61% <100.00%> (+0.10%) ⬆️
OutsideTasks 97.73% <ø> (+<0.01%) ⬆️
Files Coverage Δ
tasks/notify.py Critical 98.22% <100.00%> (-0.01%) ⬇️

... and 8 files with indirect coverage changes

Related Entrypoints
run/app.tasks.notify.Notify

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit dd4202a Jun 19, 2024
29 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/small-cleanup branch June 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants