-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small cleanup #506
small cleanup #506
Conversation
@@ -341,9 +342,6 @@ def run_impl_within_lock( | |||
) | |||
else: | |||
base_report = None | |||
head_report = report_service.get_existing_report_for_commit( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens on line 300 as well. I'm just removing the repeated operation.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 416 417 +1
Lines 34759 34795 +36
=======================================
+ Hits 33876 33912 +36
Misses 883 883
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 416 417 +1
Lines 34759 34795 +36
=======================================
+ Hits 33876 33912 +36
Misses 883 883
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 416 417 +1
Lines 34759 34795 +36
=======================================
+ Hits 33876 33912 +36
Misses 883 883
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 97.48% 97.55% +0.07%
==========================================
Files 447 448 +1
Lines 35488 36660 +1172
==========================================
+ Hits 34595 35764 +1169
- Misses 893 896 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes
|
No description provided.