Add message when upload count differs #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the "install github app" message to a dedicated section writer. I'm doing this because I want to use this new section writer to add the "number of uploads in your commit differs from base" message afterwards
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 97.26% 97.46% +0.19%
==========================================
Files 414 417 +3
Lines 34479 34796 +317
==========================================
+ Hits 33536 33913 +377
+ Misses 943 883 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 97.29% 97.50% +0.21%
==========================================
Files 445 448 +3
Lines 35208 36128 +920
==========================================
+ Hits 34255 35228 +973
+ Misses 953 900 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 97.26% 97.46% +0.19%
==========================================
Files 414 417 +3
Lines 34479 34796 +317
==========================================
+ Hits 33536 33913 +377
+ Misses 943 883 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 97.26% 97.46% +0.19%
==========================================
Files 414 417 +3
Lines 34479 34796 +317
==========================================
+ Hits 33536 33913 +377
+ Misses 943 883 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Introduces a message when the number of uploads differ and there is a significant coverage drop. The idea is that we can inform users that possibly some upload is missing, and that is the cause of the coverage drop. I had to re-work part of the logic that counts the upload diff because the sessions in a report is a `dict` object, not a `list`. Thankfully we have many tests :E
giovanni-guidini
force-pushed
the
gio/upload-count-differs-message
branch
from
0fea51c
to
2ee8a66
Compare
michelletran-codecov
approved these changes
Jun 17, 2024
Comment on lines
+24
to
+25
| if "enabled" in project_status_details: | ||
| return project_status_details["enabled"] |
There was a problem hiding this comment.
Looking at the YAML documentation for status checks, it doesn't look like enabled is a valid field for project status details?
There was a problem hiding this comment.
I take the code as the source of truth
Maybe it's a deprecated config, but there's no mention of it being deprecated
Co-authored-by: michelletran-codecov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include 2 related things:
Moving the "install github app" message to a dedicated section writer.
I'm doing this because I want to use this new section writer to add the
"number of uploads in your commit differs from base" message afterwards
Introduces a message when the number of uploads differ and there is a significant coverage drop.
The idea is that we can inform users that possibly some upload is missing, and that is the cause of the coverage drop.
I had to re-work part of the logic that counts the upload diff because the sessions in a report is a
dictobject, not alist. Thankfully we have many tests :E