Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite reports in readable format #498

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

giovanni-guidini
Copy link
Contributor

@giovanni-guidini giovanni-guidini commented Jun 10, 2024

ticket: codecov/engineering-team#1112

Apparently it was a simple naming issue in that we were passing upload_object but expecting upload_obj.
There are Sentry issues indicating 'NoneType' object has no attribute 'storage_path'

(it's expected by the function we are colling here)

ticket: codecov/engineering-team#1112

Apparently it was a simple naming issue in that we were passing `upload_object` but expecting `upload_obj`.
There are Sentry issues indicating `'NoneType' object has no attribute 'storage_path'`
@giovanni-guidini giovanni-guidini requested a review from a team June 10, 2024 11:33
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34424    34424           
=======================================
  Hits        33481    33481           
  Misses        943      943           
Flag Coverage Δ
integration 97.26% <ø> (ø)
latest-uploader-overall 97.26% <ø> (ø)
unit 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <ø> (ø)
OutsideTasks 97.54% <ø> (ø)
Files Coverage Δ
tasks/upload_processor.py 92.42% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (fb91608) to head (0de34d5).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34424    34424           
=======================================
  Hits        33481    33481           
  Misses        943      943           
Flag Coverage Δ
integration 97.26% <ø> (ø)
latest-uploader-overall 97.26% <ø> (ø)
unit 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <ø> (ø)
OutsideTasks 97.54% <ø> (ø)
Files Coverage Δ
tasks/upload_processor.py 92.42% <ø> (ø)

Copy link

codecov-public-qa bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (fb91608) to head (0de34d5).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34424    34424           
=======================================
  Hits        33481    33481           
  Misses        943      943           
Flag Coverage Δ
integration 97.26% <ø> (ø)
latest-uploader-overall 97.26% <ø> (ø)
unit 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <ø> (ø)
OutsideTasks 97.54% <ø> (ø)
Files Coverage Δ
tasks/upload_processor.py 92.42% <ø> (ø)

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (fb91608) to head (0de34d5).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         443      443           
  Lines       35153    35153           
=======================================
  Hits        34200    34200           
  Misses        953      953           
Flag Coverage Δ
integration 97.26% <ø> (ø)
latest-uploader-overall 97.26% <ø> (ø)
unit 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.46% <ø> (ø)
OutsideTasks 97.54% <ø> (ø)
Files Coverage Δ
tasks/upload_processor.py 92.96% <ø> (ø)

This change has been scanned for critical changes. Learn more

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 5cc3d3d Jun 11, 2024
29 of 30 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/fix-rewrite-readable branch June 11, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants