-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite reports in readable format #498
Conversation
ticket: codecov/engineering-team#1112 Apparently it was a simple naming issue in that we were passing `upload_object` but expecting `upload_obj`. There are Sentry issues indicating `'NoneType' object has no attribute 'storage_path'`
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34424 34424
=======================================
Hits 33481 33481
Misses 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34424 34424
=======================================
Hits 33481 33481
Misses 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34424 34424
=======================================
Hits 33481 33481
Misses 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 443 443
Lines 35153 35153
=======================================
Hits 34200 34200
Misses 953 953
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
ticket: codecov/engineering-team#1112
Apparently it was a simple naming issue in that we were passing
upload_object
but expectingupload_obj
.There are Sentry issues indicating
'NoneType' object has no attribute 'storage_path'
(it's expected by the function we are colling here)