Bundle analysis add to sizes to timeseries #493
Conversation
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
========================================
Coverage 97.29% 97.29%
========================================
Files 445 447 +2
Lines 35208 35512 +304
========================================
+ Hits 34255 34551 +296
- Misses 953 961 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #493 +/- ##
========================================
Coverage 97.26% 97.26%
========================================
Files 414 416 +2
Lines 34479 34783 +304
========================================
+ Hits 33536 33832 +296
- Misses 943 951 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #493 +/- ##
========================================
Coverage 97.26% 97.26%
========================================
Files 414 416 +2
Lines 34479 34783 +304
========================================
+ Hits 33536 33832 +296
- Misses 943 951 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #493 +/- ##
========================================
Coverage 97.26% 97.26%
========================================
Files 414 416 +2
Lines 34479 34783 +304
========================================
+ Hits 33536 33832 +296
- Misses 943 951 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| # For individual javascript associated assets using UUID | ||
| if MeasurementName.bundle_analysis_asset_size.value in dataset_names: | ||
| for asset in bundle_report.asset_reports(): | ||
| if asset.asset_type == AssetType.JAVASCRIPT: |
There was a problem hiding this comment.
is this going to be == to AssetType.JAVASCRIPT or == to AssetType.JAVASCRIPT.value? Same for the other enums
There was a problem hiding this comment.
no .value here because the asset_type is a SQLAlchemyEnum type which does the comparison without getting the actual values
| commit_yaml: dict, | ||
| previous_result: Any, | ||
| ): | ||
| repoid = int(repoid) |
There was a problem hiding this comment.
Perhaps redundant if you're expecting an int?
Yeah, the local timescale DB I showed you with the data was inserted with this PR. |
Insert bundle analysis related data points to the timeseries measurements table. Inserts six rows for each bundle,
This change adds a new task (bundle_analysis_save_measurements) that is called during the last step of the bundle_analysis_processor task. The new task will retrieve the bundle analysis report and insert the appropriate measurements to timeseries.
Creating timeseries dataset entries will be done in the API during handling of uploading the bundle file.
closes codecov/engineering-team#1769
closes codecov/engineering-team#1770
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.