Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experiment on sync_pulls #488

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

giovanni-guidini
Copy link
Contributor

This experiment aims at reducing the time we wait for a lock before giving up
in the snyc_pulls task.

For more info please see https://l.codecov.dev/DeIgE5

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This experiment aims at reducing the time we wait for a lock before giving up
in the snyc_pulls task.

For more info please see https://l.codecov.dev/DeIgE5
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         412      412              
  Lines       34150    34406     +256     
==========================================
+ Hits        33217    33464     +247     
- Misses        933      942       +9     
Flag Coverage Δ
integration 97.26% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <85.71%> (-0.01%) ⬇️
unit 97.26% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <85.71%> (+0.03%) ⬆️
OutsideTasks 97.54% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/sync_pull.py 97.66% <84.61%> (-1.09%) ⬇️

... and 21 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.26%. Comparing base (338d1c6) to head (816ff25).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         412      412              
  Lines       34150    34406     +256     
==========================================
+ Hits        33217    33464     +247     
- Misses        933      942       +9     
Flag Coverage Δ
integration 97.26% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <85.71%> (-0.01%) ⬇️
unit 97.26% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <85.71%> (+0.03%) ⬆️
OutsideTasks 97.54% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/sync_pull.py 97.66% <84.61%> (-1.09%) ⬇️

... and 21 files with indirect coverage changes

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.40%. Comparing base (338d1c6) to head (816ff25).
Report is 5 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   97.29%   97.40%   +0.10%     
==========================================
  Files         443      443              
  Lines       34879    36481    +1602     
==========================================
+ Hits        33936    35533    +1597     
- Misses        943      948       +5     
Flag Coverage Δ
integration 97.26% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <85.71%> (-0.01%) ⬇️
unit 97.26% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.68% <85.71%> (+0.25%) ⬆️
OutsideTasks 97.54% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/sync_pull.py 97.67% <84.61%> (-1.08%) ⬇️

... and 21 files with indirect coverage changes

Related Entrypoints
run/app.tasks.pulls.Sync

Copy link

codecov-public-qa bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.26%. Comparing base (338d1c6) to head (816ff25).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         412      412              
  Lines       34150    34406     +256     
==========================================
+ Hits        33217    33464     +247     
- Misses        933      942       +9     
Flag Coverage Δ
integration 97.26% <85.71%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <85.71%> (-0.01%) ⬇️
unit 97.26% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.41% <85.71%> (+0.03%) ⬆️
OutsideTasks 97.54% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
rollouts/__init__.py 100.00% <100.00%> (ø)
tasks/sync_pull.py 97.66% <84.61%> (-1.09%) ⬇️

... and 21 files with indirect coverage changes

@giovanni-guidini giovanni-guidini requested a review from a team June 5, 2024 10:12
@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit fb91608 Jun 7, 2024
24 of 30 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/experiment-sync-lock-time branch June 7, 2024 11:25
adrian-codecov pushed a commit that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants