Bundle Analysis: associate past assets to current parsed bundle #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
changed the title
JerrySentry
commented
Jun 3, 2024
| @@ -123,6 +123,41 @@ async def initialize_and_save_report( | |||
| db_session.flush() | |||
| return commit_report | |||
|
|
|||
There was a problem hiding this comment.
This file is the only real change to this PR, everything else is ruff generated fixes and unit tests.
There was a problem hiding this comment.
Why were there so many changes? are you using a different version of ruff and/or did we recently update it?
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 97.24% 97.26% +0.02%
==========================================
Files 412 412
Lines 34265 34393 +128
==========================================
+ Hits 33321 33453 +132
+ Misses 944 940 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 97.24% 97.26% +0.02%
==========================================
Files 412 412
Lines 34265 34393 +128
==========================================
+ Hits 33321 33453 +132
+ Misses 944 940 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 97.27% 97.29% +0.02%
==========================================
Files 443 443
Lines 34994 35122 +128
==========================================
+ Hits 34040 34172 +132
+ Misses 954 950 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 97.24% 97.26% +0.02%
==========================================
Files 412 412
Lines 34265 34393 +128
==========================================
+ Hits 33321 33453 +132
+ Misses 944 940 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to codecov/shared#231
Retrieve the previous bundle analysis report during processing of current bundle analysis report, then send it to
BundleAnalysisReport.associate_previous_assetsto process asset association.closes: codecov/engineering-team#1768
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.