Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy config for pre-commit #485

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

giovanni-guidini
Copy link
Contributor

@giovanni-guidini giovanni-guidini commented Jun 3, 2024

Fixes the mypy config in the pre-commit hook so it actually runs.
Apparently it doesn't like the "type" keyworkd, so removing that

ps.: fixing in CI depends on codecov/gha-workflows#26

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes the mypy config in the pre-commit hook so it actually runs.
Apparently it doesn't like the "type" keyworkd, so removing that
@giovanni-guidini giovanni-guidini requested a review from a team June 3, 2024 16:38
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34150    34150           
=======================================
  Hits        33217    33217           
  Misses        933      933           
Flag Coverage Δ
integration 97.26% <100.00%> (ø)
latest-uploader-overall 97.26% <100.00%> (ø)
unit 97.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (ø)
OutsideTasks 97.52% <100.00%> (ø)
Files Coverage Δ
services/bots/types.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (338d1c6) to head (20d9c98).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34150    34150           
=======================================
  Hits        33217    33217           
  Misses        933      933           
Flag Coverage Δ
integration 97.26% <100.00%> (ø)
latest-uploader-overall 97.26% <100.00%> (ø)
unit 97.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (ø)
OutsideTasks 97.52% <100.00%> (ø)
Files Coverage Δ
services/bots/types.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (338d1c6) to head (20d9c98).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         443      443           
  Lines       34879    34879           
=======================================
  Hits        33936    33936           
  Misses        943      943           
Flag Coverage Δ
integration 97.26% <100.00%> (ø)
latest-uploader-overall 97.26% <100.00%> (ø)
unit 97.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.43% <100.00%> (ø)
OutsideTasks 97.52% <100.00%> (ø)
Files Coverage Δ
services/bots/types.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

Copy link

codecov-public-qa bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (338d1c6) to head (20d9c98).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34150    34150           
=======================================
  Hits        33217    33217           
  Misses        933      933           
Flag Coverage Δ
integration 97.26% <100.00%> (ø)
latest-uploader-overall 97.26% <100.00%> (ø)
unit 97.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (ø)
OutsideTasks 97.52% <100.00%> (ø)
Files Coverage Δ
services/bots/types.py 100.00% <100.00%> (ø)

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 4fe84f0 Jun 4, 2024
29 of 30 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/fix-mypy-local branch June 4, 2024 13:49
adrian-codecov pushed a commit that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants