Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove List Repos Generator Exp Control Path #480

Merged
merged 1 commit into from
May 31, 2024

Conversation

ajay-sentry
Copy link
Contributor

This PR aims to remove the "control" code related to the list repos generator experiment.

Related notion doc: https://www.notion.so/sentry/LIST_REPOS_GENERATOR-435d23a072034036b5b29e0ff79aab3e
Code has been running at 100% exp since May 13 2024.
Metabase link

TESTING

  • Ran on Gazebo manually syncing repos, confirmed no error thrown, all repos look to still be shown on the screen

Screenshot 2024-05-31 at 9 23 37 AM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34187    34122   -65     
=======================================
- Hits        33252    33189   -63     
+ Misses        935      933    -2     
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (-0.01%) ⬇️
OutsideTasks 97.52% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/backfills.py 100.00% <ø> (ø)
rollouts/__init__.py 100.00% <ø> (ø)
tasks/sync_repos.py 97.12% <100.00%> (-0.17%) ⬇️
...nit/test_backfill_existing_gh_app_installations.py 100.00% <ø> (ø)
...st_backfill_owners_without_gh_app_installations.py 100.00% <ø> (ø)
tasks/tests/unit/test_sync_repos_task.py 99.42% <100.00%> (+0.42%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4a0347d) to head (1408324).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34187    34122   -65     
=======================================
- Hits        33252    33189   -63     
+ Misses        935      933    -2     
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (-0.01%) ⬇️
OutsideTasks 97.52% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/backfills.py 100.00% <ø> (ø)
rollouts/__init__.py 100.00% <ø> (ø)
tasks/sync_repos.py 97.12% <100.00%> (-0.17%) ⬇️
...nit/test_backfill_existing_gh_app_installations.py 100.00% <ø> (ø)
...st_backfill_owners_without_gh_app_installations.py 100.00% <ø> (ø)
tasks/tests/unit/test_sync_repos_task.py 99.42% <100.00%> (+0.42%) ⬆️

Copy link

codecov-public-qa bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4a0347d) to head (1408324).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         412      412           
  Lines       34187    34122   -65     
=======================================
- Hits        33252    33189   -63     
+ Misses        935      933    -2     
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (-0.01%) ⬇️
OutsideTasks 97.52% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/backfills.py 100.00% <ø> (ø)
rollouts/__init__.py 100.00% <ø> (ø)
tasks/sync_repos.py 97.12% <100.00%> (-0.17%) ⬇️
...nit/test_backfill_existing_gh_app_installations.py 100.00% <ø> (ø)
...st_backfill_owners_without_gh_app_installations.py 100.00% <ø> (ø)
tasks/tests/unit/test_sync_repos_task.py 99.42% <100.00%> (+0.42%) ⬆️

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (4a0347d) to head (1408324).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   97.29%   97.29%   -0.01%     
==========================================
  Files         443      443              
  Lines       34916    34851      -65     
==========================================
- Hits        33972    33908      -64     
+ Misses        944      943       -1     
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.42% <100.00%> (-0.01%) ⬇️
OutsideTasks 97.52% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/backfills.py 100.00% <ø> (ø)
rollouts/__init__.py 100.00% <ø> (ø)
tasks/sync_repos.py 97.14% <100.00%> (-0.17%) ⬇️
...nit/test_backfill_existing_gh_app_installations.py 100.00% <ø> (ø)
...st_backfill_owners_without_gh_app_installations.py 100.00% <ø> (ø)
tasks/tests/unit/test_sync_repos_task.py 99.42% <100.00%> (+0.17%) ⬆️
Related Entrypoints
run/app.tasks.sync_repos.SyncRepos

@ajay-sentry ajay-sentry added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 2d39bca May 31, 2024
29 of 30 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/1667-remove-list-repos-exp branch May 31, 2024 17:24
Copy link

sentry-io bot commented Jun 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TorngitUnauthorizedError: Github API unauthorized error: Unauthorized app.tasks.sync_repos.SyncRepos View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants