Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denoise an obnoxious log #477

Merged
merged 1 commit into from
May 29, 2024
Merged

denoise an obnoxious log #477

merged 1 commit into from
May 29, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented May 29, 2024

instead of logging the full set of path fixes, log the "first" 10, and skip logging a full table of contents ("toc")

the fixes and toc keys in this log can potentially have an item for every file in the repository. GCP collapses big logs into a smaller row that you can click to expand, but apparently a log can be so big that it will actually be split across several rows, and in at least one case the log was so big that it took up screenful after screenful and made investigating the issue i was working on much harder

@codecov-notifications
Copy link

codecov-notifications bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34152    34153    +1     
=======================================
+ Hits        33217    33218    +1     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 93.96% <100.00%> (+0.03%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (d3c9650) to head (2c0d8fc).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34152    34153    +1     
=======================================
+ Hits        33217    33218    +1     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 93.96% <100.00%> (+0.03%) ⬆️

@matt-codecov matt-codecov requested a review from a team May 29, 2024 19:55
Copy link

codecov-public-qa bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (d3c9650) to head (2c0d8fc).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34152    34153    +1     
=======================================
+ Hits        33217    33218    +1     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 93.96% <100.00%> (+0.03%) ⬆️

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (d3c9650) to head (2c0d8fc).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         442      442           
  Lines       34881    34882    +1     
=======================================
+ Hits        33937    33938    +1     
  Misses        944      944           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.43% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/raw_upload_processor.py 93.96% <100.00%> (+0.03%) ⬆️

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 2492b5e May 29, 2024
29 of 30 checks passed
@matt-codecov matt-codecov deleted the pr477 branch May 29, 2024 20:04
@thomasrockhu-codecov
Copy link
Contributor

@matt-codecov I think I would have preferred closer to 100 lines. Particularly in the case of needing to see if there are multiple directories in the toc. However, this is more a nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants