-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create django version of the repository and bots services #476
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 97.26% 97.30% +0.03%
==========================================
Files 411 421 +10
Lines 34146 35121 +975
==========================================
+ Hits 33211 34173 +962
- Misses 935 948 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 97.26% 97.30% +0.03%
==========================================
Files 411 421 +10
Lines 34146 35121 +975
==========================================
+ Hits 33211 34173 +962
- Misses 935 948 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 97.26% 97.30% +0.03%
==========================================
Files 411 421 +10
Lines 34146 35121 +975
==========================================
+ Hits 33211 34173 +962
- Misses 935 948 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 97.29% 97.33% +0.03%
==========================================
Files 442 452 +10
Lines 34875 35866 +991
==========================================
+ Hits 33931 34909 +978
- Misses 944 957 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
Signed-off-by: joseph-sentry <[email protected]>
Can we instead change the bots services to be database agnostic? It doesn't seem great to have 2 different copies of such important services - that would have to be maintained both, and is being actively worked on - in the same project. Especially without a clear deprecation date for the SQLAlchemy models. I believe there's a way to make this service database agnostic so you can pass either model and have it still work (with helper functions for the models methods and fields, mostly) that would be better for us long-term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead change the bots services to be database agnostic?
It doesn't seem great to have 2 different copies of such important services - that would have to be maintained both, and is being actively worked on - in the same project. Especially without a clear deprecation date for the SQLAlchemy models.
I believe there's a way to make this service database agnostic so you can pass either model and have it still work (with helper functions for the models methods and fields, mostly) that would be better for us long-term.
This PR creates copies of the repository and bots services that use the Django models instead of the SQLAlchemy models. This is so that the test results finisher can use the django models instead of the SQLAlchemy models.
Note: there is a difference in the behaviour we're verifying between the regular repository service tests and the django repository service tests. One example is
test_fetch_and_update_pull_request_information_no_compared_to