Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete outdated/noisy log #474

Merged
merged 1 commit into from
May 28, 2024
Merged

delete outdated/noisy log #474

merged 1 commit into from
May 28, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented May 28, 2024

i think the new report endpoint that the CLI's create-report command hits will create a CommitReport without creating a ReportDetails (link) so this log is not actually unexpected and fires way too much

@matt-codecov matt-codecov requested a review from a team May 28, 2024 21:18
@codecov-notifications
Copy link

codecov-notifications bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34142       -1     
==========================================
- Hits        33209    33208       -1     
  Misses        934      934              
Flag Coverage Δ
integration 97.26% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.26% <ø> (-0.01%) ⬇️
unit 97.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <ø> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (-0.01%) ⬇️
Files Coverage Δ
services/report/__init__.py 92.30% <ø> (-0.02%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4d733c2) to head (1b5c03e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34142       -1     
==========================================
- Hits        33209    33208       -1     
  Misses        934      934              
Flag Coverage Δ
integration 97.26% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.26% <ø> (-0.01%) ⬇️
unit 97.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <ø> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (-0.01%) ⬇️
Files Coverage Δ
services/report/__init__.py 92.30% <ø> (-0.02%) ⬇️

Copy link

codecov-public-qa bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (4d733c2) to head (1b5c03e).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34142       -1     
==========================================
- Hits        33209    33208       -1     
  Misses        934      934              
Flag Coverage Δ
integration 97.26% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.26% <ø> (-0.01%) ⬇️
unit 97.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <ø> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (-0.01%) ⬇️
Files Coverage Δ
services/report/__init__.py 92.30% <ø> (-0.02%) ⬇️

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (4d733c2) to head (1b5c03e).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   97.29%   97.29%   -0.01%     
==========================================
  Files         442      442              
  Lines       34872    34871       -1     
==========================================
- Hits        33929    33928       -1     
  Misses        943      943              
Flag Coverage Δ
integration 97.26% <ø> (-0.01%) ⬇️
latest-uploader-overall 97.26% <ø> (-0.01%) ⬇️
unit 97.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.43% <ø> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (-0.01%) ⬇️
Files Coverage Δ
services/report/__init__.py Critical 92.32% <ø> (-0.02%) ⬇️

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit b75115d May 28, 2024
29 of 30 checks passed
@matt-codecov matt-codecov deleted the pr474 branch May 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants