Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add commit sha to sentry trace tags #473

Merged
merged 1 commit into from
May 28, 2024
Merged

add commit sha to sentry trace tags #473

merged 1 commit into from
May 28, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented May 28, 2024

rather than searching for a commit sha in GCP logs to get celery task IDs and then checking if those celery task IDs exist in sentry, let's make it possible to just search the commit sha in sentry

@matt-codecov matt-codecov requested a review from a team May 28, 2024 20:18
@codecov-qa
Copy link

codecov-qa bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.26%. Comparing base (4d733c2) to head (8be5d11).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34147       +4     
==========================================
+ Hits        33209    33212       +3     
- Misses        934      935       +1     
Flag Coverage Δ
integration 97.26% <75.00%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <75.00%> (-0.01%) ⬇️
unit 97.26% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <75.00%> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (ø)
Files Coverage Δ
tasks/base.py 96.02% <75.00%> (-0.49%) ⬇️

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34147       +4     
==========================================
+ Hits        33209    33212       +3     
- Misses        934      935       +1     
Flag Coverage Δ
integration 97.26% <75.00%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <75.00%> (-0.01%) ⬇️
unit 97.26% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <75.00%> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (ø)
Files Coverage Δ
tasks/base.py 96.02% <75.00%> (-0.49%) ⬇️

Copy link

codecov-public-qa bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.26%. Comparing base (4d733c2) to head (8be5d11).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         411      411              
  Lines       34143    34147       +4     
==========================================
+ Hits        33209    33212       +3     
- Misses        934      935       +1     
Flag Coverage Δ
integration 97.26% <75.00%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <75.00%> (-0.01%) ⬇️
unit 97.26% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <75.00%> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (ø)
Files Coverage Δ
tasks/base.py 96.02% <75.00%> (-0.49%) ⬇️

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.29%. Comparing base (4d733c2) to head (8be5d11).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   97.29%   97.29%   -0.01%     
==========================================
  Files         442      442              
  Lines       34872    34876       +4     
==========================================
+ Hits        33929    33932       +3     
- Misses        943      944       +1     
Flag Coverage Δ
integration 97.26% <75.00%> (-0.01%) ⬇️
latest-uploader-overall 97.26% <75.00%> (-0.01%) ⬇️
unit 97.26% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.42% <75.00%> (-0.01%) ⬇️
OutsideTasks 97.51% <ø> (ø)
Files Coverage Δ
tasks/base.py Critical 96.02% <75.00%> (-0.49%) ⬇️

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 5285a97 May 28, 2024
17 of 30 checks passed
@matt-codecov matt-codecov deleted the pr473 branch May 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants