Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Analysis: Add to timeseries MeasurementName enum #471

Merged
merged 3 commits into from
May 29, 2024

Conversation

JerrySentry
Copy link
Contributor

Adds some timeseries measurement types to be used for various bundle analysis trend analytics.

closes: codecov/engineering-team#1765

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (5285a97) to head (0908154).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34146    34152    +6     
=======================================
+ Hits        33211    33217    +6     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/models/timeseries.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34146    34152    +6     
=======================================
+ Hits        33211    33217    +6     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/models/timeseries.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (5285a97) to head (0908154).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         411      411           
  Lines       34146    34152    +6     
=======================================
+ Hits        33211    33217    +6     
  Misses        935      935           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.37% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/models/timeseries.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (5285a97) to head (0908154).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         442      442           
  Lines       34875    34881    +6     
=======================================
+ Hits        33931    33937    +6     
  Misses        944      944           
Flag Coverage Δ
integration 97.26% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.26% <100.00%> (+<0.01%) ⬆️
unit 97.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.42% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.51% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/models/timeseries.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@JerrySentry JerrySentry added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit d3c9650 May 29, 2024
29 of 30 checks passed
@JerrySentry JerrySentry deleted the may_28_ba_measurement_enum branch May 29, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Worker] Add bundle measurements to MeasurementName enum
2 participants