Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "flow logger" + instrument upload flow with it #47

Merged
merged 4 commits into from
Aug 16, 2023

Merge branch 'main' into matt/add-upload-flow-logs

aacbd27
Select commit
Loading
Failed to load commit list.
Merged

feat: add "flow logger" + instrument upload flow with it #47

Merge branch 'main' into matt/add-upload-flow-logs
aacbd27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 16, 2023 in 0s

98.59% (-0.01%) compared to 76c780f

View this Pull Request on Codecov

98.59% (-0.01%) compared to 76c780f

Details

Codecov Report

Merging #47 (aacbd27) into main (76c780f) will decrease coverage by 0.01%.
The diff coverage is 98.22%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files         357      359       +2     
  Lines       26004    26275     +271     
==========================================
+ Hits        25639    25905     +266     
- Misses        365      370       +5     
Components Coverage Δ
NonTestCode 97.29% <94.73%> (-0.03%) ⬇️
OutsideTasks 98.34% <99.48%> (+0.01%) ⬆️
Files Changed Coverage Δ
tasks/upload_finisher.py 97.11% <80.00%> (-1.83%) ⬇️
tasks/upload.py Critical 98.21% <90.90%> (-0.83%) ⬇️
helpers/checkpoint_logger.py 98.33% <98.33%> (ø)
conftest.py 94.44% <100.00%> (+0.47%) ⬆️
helpers/tests/unit/test_checkpoint_logger.py 100.00% <100.00%> (ø)
tasks/notify.py Critical 98.78% <100.00%> (+0.02%) ⬆️
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.44% <100.00%> (+0.01%) ⬆️
Related Entrypoints
run/app.tasks.upload.Upload