Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Upgrade stripe to latest #456

Merged
merged 2 commits into from
May 17, 2024
Merged

dev: Upgrade stripe to latest #456

merged 2 commits into from
May 17, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented May 16, 2024

Upgrades stripe to latest API version

Related Ticket: codecov/engineering-team#1754

Main changes found here: codecov/codecov-api#569

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   97.34%   97.35%           
=======================================
  Files         399      401    +2     
  Lines       33611    33665   +54     
=======================================
+ Hits        32719    32773   +54     
  Misses        892      892           
Flag Coverage Δ
integration 97.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.35% <100.00%> (+<0.01%) ⬆️
unit 97.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.59% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (5ab507b) to head (262678c).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   97.34%   97.35%           
=======================================
  Files         399      401    +2     
  Lines       33611    33665   +54     
=======================================
+ Hits        32719    32773   +54     
  Misses        892      892           
Flag Coverage Δ
integration 97.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.35% <100.00%> (+<0.01%) ⬆️
unit 97.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.59% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link

codecov-public-qa bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (5ab507b) to head (262678c).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   97.34%   97.35%           
=======================================
  Files         399      401    +2     
  Lines       33611    33665   +54     
=======================================
+ Hits        32719    32773   +54     
  Misses        892      892           
Flag Coverage Δ
integration 97.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.35% <100.00%> (+<0.01%) ⬆️
unit 97.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.59% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (5ab507b) to head (262678c).
Report is 5 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   97.37%   97.41%   +0.04%     
==========================================
  Files         430      432       +2     
  Lines       34301    34744     +443     
==========================================
+ Hits        33400    33846     +446     
+ Misses        901      898       -3     
Flag Coverage Δ
integration 97.35% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.35% <100.00%> (+<0.01%) ⬆️
unit 97.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.74% <100.00%> (+0.13%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

@ajay-sentry ajay-sentry added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 2637eef May 17, 2024
30 checks passed
@ajay-sentry ajay-sentry deleted the stripe-upgrade-latest branch May 17, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants