Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update message when PR head differs #451

Merged
merged 1 commit into from
May 16, 2024

Conversation

giovanni-guidini
Copy link
Contributor

ticket: codecov/engineering-team#1595

Change message when the HEAD of the PR we have is not up to date with
the PR's most recent head.
Makes the message more actionable.
Check ticket for further info.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

ticket: codecov/engineering-team#1595

Change message when the HEAD of the PR we have is not up to date with
the PR's most recent head.
Makes the message more actionable.
Check ticket for further info.
@codecov-notifications
Copy link

codecov-notifications bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33614    +4     
=======================================
+ Hits        32718    32722    +4     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 97.01% <100.00%> (+0.03%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (3d44c4e) to head (863f10c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33614    +4     
=======================================
+ Hits        32718    32722    +4     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 97.01% <100.00%> (+0.03%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)

Copy link

codecov-public-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (3d44c4e) to head (863f10c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33614    +4     
=======================================
+ Hits        32718    32722    +4     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 97.01% <100.00%> (+0.03%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 99.22% <ø> (ø)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (3d44c4e) to head (863f10c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         430      430           
  Lines       34300    34304    +4     
=======================================
+ Hits        33399    33403    +4     
  Misses        901      901           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.61% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
.../notification/notifiers/mixins/message/sections.py 96.14% <100.00%> (+0.05%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 99.27% <ø> (ø)

This change has been scanned for critical changes. Learn more

@giovanni-guidini giovanni-guidini requested a review from a team May 15, 2024 17:46
@giovanni-guidini giovanni-guidini added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 242e1a0 May 16, 2024
29 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/improve-different-head-message branch May 16, 2024 08:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants