Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Pin Stripe Version to V8 #450

Merged
merged 2 commits into from
May 15, 2024
Merged

dev: Pin Stripe Version to V8 #450

merged 2 commits into from
May 15, 2024

Conversation

ajay-sentry
Copy link
Contributor

Pins stripe version to 2023 version

Related docs

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33611    +1     
=======================================
+ Hits        32718    32719    +1     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (0c7829b) to head (5b3d6ac).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33611    +1     
=======================================
+ Hits        32718    32719    +1     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (0c7829b) to head (5b3d6ac).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33610    33611    +1     
=======================================
+ Hits        32718    32719    +1     
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (0c7829b) to head (5b3d6ac).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         430      430           
  Lines       34300    34301    +1     
=======================================
+ Hits        33399    33400    +1     
  Misses        901      901           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.34% <100.00%> (+<0.01%) ⬆️
unit 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.60% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.50% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/stripe.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@ajay-sentry ajay-sentry added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 5ab507b May 15, 2024
29 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/pin-stripe-version branch May 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants