fix: get_repo_appropriate_bot_token returning None #403
Conversation
get_repo_appropriate_bot_token is returning None in some cases which is causing issues because it's expected to return a: Tuple[Dict, Optional[Owner]]. I think the only way it can possibly return None is if get_public_token returns None, which is possible if we don't enter the if statement in get_public_token. So, if we don't enter it now, we now return a RepositoryWithoutValidBotError exception. Signed-off-by: joseph-sentry <[email protected]>
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33372 +2
==========================================
Hits 32533 32533
- Misses 837 839 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33372 +2
==========================================
Hits 32533 32533
- Misses 837 839 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.01%
==========================================
Files 395 395
Lines 33370 33372 +2
==========================================
Hits 32533 32533
- Misses 837 839 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 97.51% 97.50% -0.01%
==========================================
Files 426 426
Lines 34070 34072 +2
==========================================
Hits 33223 33223
- Misses 847 849 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
get_repo_appropriate_bot_token is returning None in some cases which is causing issues because it's expected to return a:
Tuple[Dict, Optional[Owner]].
I think the only way it can possibly return None is if get_public_token returns None, which is possible if we don't enter the if statement in get_public_token. So, if we don't enter it now, we now return a RepositoryWithoutValidBotError exception.
Fixes: https://codecov.sentry.io/issues/5238383824/?project=4505562667089920&referrer=github-pr-bot