Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert shared pr #397

Merged
merged 1 commit into from
Apr 18, 2024
Merged

revert shared pr #397

merged 1 commit into from
Apr 18, 2024

Conversation

adrian-codecov
Copy link
Contributor

Manual revert of #382. Updated req.in to the latest one though

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   97.49%   97.50%           
=======================================
  Files         395      395           
  Lines       33263    33261    -2     
=======================================
  Hits        32430    32430           
+ Misses        833      831    -2     
Flag Coverage Δ
integration 97.50% <0.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <0.00%> (+<0.01%) ⬆️
unit 97.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.89% <0.00%> (+0.01%) ⬆️
OutsideTasks 97.60% <0.00%> (+<0.01%) ⬆️
Files Coverage Δ
django_scaffold/settings.py 0.00% <0.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.50%. Comparing base (f5be738) to head (0c51ca7).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   97.49%   97.50%           
=======================================
  Files         395      395           
  Lines       33263    33261    -2     
=======================================
  Hits        32430    32430           
+ Misses        833      831    -2     
Flag Coverage Δ
integration 97.50% <0.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <0.00%> (+<0.01%) ⬆️
unit 97.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.89% <0.00%> (+0.01%) ⬆️
OutsideTasks 97.60% <0.00%> (+<0.01%) ⬆️
Files Coverage Δ
django_scaffold/settings.py 0.00% <0.00%> (ø)

Copy link

codecov-public-qa bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.50%. Comparing base (f5be738) to head (0c51ca7).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   97.49%   97.50%           
=======================================
  Files         395      395           
  Lines       33263    33261    -2     
=======================================
  Hits        32430    32430           
+ Misses        833      831    -2     
Flag Coverage Δ
integration 97.50% <0.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <0.00%> (+<0.01%) ⬆️
unit 97.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.89% <0.00%> (+0.01%) ⬆️
OutsideTasks 97.60% <0.00%> (+<0.01%) ⬆️
Files Coverage Δ
django_scaffold/settings.py 0.00% <0.00%> (ø)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.51%. Comparing base (f5be738) to head (0c51ca7).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         426      426           
  Lines       33963    33961    -2     
=======================================
  Hits        33118    33118           
+ Misses        845      843    -2     
Flag Coverage Δ
integration 97.50% <0.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.50% <0.00%> (+<0.01%) ⬆️
unit 97.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.89% <0.00%> (+0.01%) ⬆️
OutsideTasks 97.60% <0.00%> (+<0.01%) ⬆️
Files Coverage Δ
django_scaffold/settings.py 0.00% <0.00%> (ø)

This change has been scanned for critical changes. Learn more

@adrian-codecov adrian-codecov merged commit 3de71f4 into main Apr 18, 2024
39 of 43 checks passed
@adrian-codecov adrian-codecov deleted the undo-shared-models branch April 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants