Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: except LockRetry instead of LockError #372

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

joseph-sentry
Copy link
Contributor

Fixes: https://codecov.sentry.io/issues/5057432400/?project=-1&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=1&utc=true

We should be excepting a LockRetry here because that is what LockManager throws when it hits an error when trying to acquire the lock

@joseph-sentry joseph-sentry requested a review from a team April 9, 2024 18:01
Copy link

sentry-io bot commented Apr 9, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/notify.py

Function Unhandled Issue
run_impl LockRetry: 143 app.tasks.notify.Notify
Event Count: 1.0k

Did you find this useful? React with a 👍 or 👎

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         393      393           
  Lines       32900    32901    +1     
=======================================
+ Hits        32094    32095    +1     
  Misses        806      806           
Flag Coverage Δ
integration 97.55% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.55% <100.00%> (+<0.01%) ⬆️
unit 97.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.91% <100.00%> (ø)
OutsideTasks 97.78% <ø> (ø)
Files Coverage Δ
tasks/notify.py 98.50% <100.00%> (ø)
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (7d9c198) to head (65eb83f).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         393      393           
  Lines       32900    32901    +1     
=======================================
+ Hits        32094    32095    +1     
  Misses        806      806           
Flag Coverage Δ
integration 97.55% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.55% <100.00%> (+<0.01%) ⬆️
unit 97.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.91% <100.00%> (ø)
OutsideTasks 97.78% <ø> (ø)
Files Coverage Δ
tasks/notify.py 98.50% <100.00%> (ø)
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (7d9c198) to head (65eb83f).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         393      393           
  Lines       32900    32901    +1     
=======================================
+ Hits        32094    32095    +1     
  Misses        806      806           
Flag Coverage Δ
integration 97.55% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.55% <100.00%> (+<0.01%) ⬆️
unit 97.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.91% <100.00%> (ø)
OutsideTasks 97.78% <ø> (ø)
Files Coverage Δ
tasks/notify.py 98.50% <100.00%> (ø)
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (7d9c198) to head (65eb83f).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         424      424           
  Lines       33600    33601    +1     
=======================================
+ Hits        32782    32783    +1     
  Misses        818      818           
Flag Coverage Δ
integration 97.55% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.55% <100.00%> (+<0.01%) ⬆️
unit 97.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.91% <100.00%> (ø)
OutsideTasks 97.78% <ø> (ø)
Files Coverage Δ
tasks/notify.py Critical 98.50% <100.00%> (ø)
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)
Related Entrypoints
run/app.tasks.notify.Notify

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@joseph-sentry joseph-sentry force-pushed the joseph/fix-sentry-error branch 3 times, most recently from 732f133 to 87bce18 Compare April 11, 2024 15:34
@joseph-sentry joseph-sentry merged commit 07405e0 into main Apr 11, 2024
30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-sentry-error branch April 11, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants