-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: except LockRetry instead of LockError #372
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/notify.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 393 393
Lines 32900 32901 +1
=======================================
+ Hits 32094 32095 +1
Misses 806 806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 393 393
Lines 32900 32901 +1
=======================================
+ Hits 32094 32095 +1
Misses 806 806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 393 393
Lines 32900 32901 +1
=======================================
+ Hits 32094 32095 +1
Misses 806 806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 424 424
Lines 33600 33601 +1
=======================================
+ Hits 32782 32783 +1
Misses 818 818
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
732f133
to
87bce18
Compare
Signed-off-by: joseph-sentry <[email protected]>
87bce18
to
65eb83f
Compare
Fixes: https://codecov.sentry.io/issues/5057432400/?project=-1&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=1&utc=true
We should be excepting a
LockRetry
here because that is whatLockManager
throws when it hits an error when trying to acquire the lock