-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webhook redelivery task needs async for #367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 97.79% 98.08% +0.29%
==========================================
Files 392 392
Lines 32748 32566 -182
==========================================
- Hits 32025 31943 -82
+ Misses 723 623 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 97.79% 97.79% -0.01%
==========================================
Files 392 392
Lines 32748 32746 -2
==========================================
- Hits 32025 32023 -2
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 97.79% 97.79% -0.01%
==========================================
Files 392 392
Lines 32748 32746 -2
==========================================
- Hits 32025 32023 -2
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 97.80% 97.80% -0.01%
==========================================
Files 423 423
Lines 33448 33446 -2
==========================================
- Hits 32713 32711 -2
Misses 735 735
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
my bad, broke this in #304
this is evidence that we need proper integration tests (see https://github.com/codecov/integration-tests)
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.