-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate flaky test detection into test results finisher #342
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 97.52% 97.48% -0.05%
==========================================
Files 394 395 +1
Lines 32964 33193 +229
==========================================
+ Hits 32147 32357 +210
- Misses 817 836 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 97.52% 97.48% -0.05%
==========================================
Files 394 395 +1
Lines 32964 33193 +229
==========================================
+ Hits 32147 32357 +210
- Misses 817 836 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 97.52% 97.48% -0.05%
==========================================
Files 394 395 +1
Lines 32964 33193 +229
==========================================
+ Hits 32147 32357 +210
- Misses 817 836 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 97.53% 97.49% -0.04%
==========================================
Files 425 426 +1
Lines 33664 33893 +229
==========================================
+ Hits 32835 33045 +210
- Misses 829 848 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
4067778
to
628c28e
Compare
628c28e
to
abb529c
Compare
bcc5103
to
6f117e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't spot any copy typos and general logic looks sound
- Add a FLAKY_TEST_DETECTION rollout - Add dedicated tests for the test results module - Add flake info to the test results PR comment - Run flaky test detection after creating the associated objects in the db for test results ingestion
6f117e3
to
4f5d33e
Compare
Depends on:
codecov/shared#184
This PR does not make any changes to the database: existing flakes won't be retrieved, new flakes won't be stored, flakes will be recalculated every time we run the test results finisher.