Refactor test results finisher tests #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.02%
==========================================
Files 387 387
Lines 32115 31864 -251
==========================================
- Hits 31510 31259 -251
Misses 605 605
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.02%
==========================================
Files 387 387
Lines 32115 31864 -251
==========================================
- Hits 31510 31259 -251
Misses 605 605
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 98.11% 98.09% -0.02%
==========================================
Files 418 418
Lines 32815 32564 -251
==========================================
- Hits 32195 31944 -251
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
This commit refactors the test results finisher tests into fixtures, all functionality expected from the finisher task is being tested: - failure message escaping - path shortening - failure message deduplication - multi env failure - default env failure - upload after another - comment table formatting
joseph-sentry
force-pushed
the
joseph/refactor-test-results-finisher-tests
branch
from
b1eb2da
to
49d9ef8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.02%
==========================================
Files 387 387
Lines 32115 31864 -251
==========================================
- Hits 31510 31259 -251
Misses 605 605
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #310
This commit refactors the test results finisher tests into fixtures, all functionality expected from the finisher task is being tested: