fix: update Feature interface #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 385 385
Lines 31901 31901
=======================================
Hits 31302 31302
Misses 599 599
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 385 385
Lines 31901 31901
=======================================
Hits 31302 31302
Misses 599 599
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 416 416
Lines 32601 32601
=======================================
Hits 31984 31984
Misses 617 617
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
matt-codecov
approved these changes
Mar 6, 2024
daniel-codecov
force-pushed
the
daniel/update-feature-interface
branch
from
e9c9ba3
to
868c6a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage ? 98.12%
=======================================
Files ? 385
Lines ? 31901
Branches ? 0
=======================================
Hits ? 31302
Misses ? 599
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Feature interface to match the
check_value()signature here codecov/shared#141. Need to update the shared hash once the ^ PR gets mergedAlso removes salt/proportion param from
Featureaccording to this codecov/shared#142Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.