chore: use debian base images instead of alpine #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 425 425
Lines 33597 33597
=======================================
Hits 32776 32776
Misses 821 821
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 394 394
Lines 32897 32897
=======================================
Hits 32089 32089
Misses 808 808
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 394 394
Lines 32897 32897
=======================================
Hits 32089 32089
Misses 808 808
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 394 394
Lines 32897 32897
=======================================
Hits 32089 32089
Misses 808 808
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
added a commit
that referenced
this pull request
Mar 29, 2024
I'm copying the changes because that PR is far behind `main`. We will probably wait for the base image change to happen before merging this update work though
nora-codecov
force-pushed
the
matt/debian-base-image
branch
2 times, most recently
from
57fb9f6
to
a33403f
Compare
nora-codecov
force-pushed
the
matt/debian-base-image
branch
2 times, most recently
from
afb79fc
to
c393808
Compare
nora-codecov
force-pushed
the
matt/debian-base-image
branch
from
c393808
to
f077576
Compare
trent-codecov
approved these changes
Apr 15, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Apr 26, 2024
I'm copying the changes because that PR is far behind `main`. We will probably wait for the base image change to happen before merging this update work though
giovanni-guidini
added a commit
that referenced
this pull request
Apr 29, 2024
I'm copying the changes because that PR is far behind `main`. We will probably wait for the base image change to happen before merging this update work though
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* copy changes from #285 I'm copying the changes because that PR is far behind `main`. We will probably wait for the base image change to happen before merging this update work though * upgrade packages until project builds and tests run * fix tests * disable mutation testing * fix: Fix pytest-cov performance Solution from nedbat/coveragepy#1665 (comment) Thanks @trent-codecov for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes codecov/engineering-team#1242
with an alpine/musl image we have to build more packages from source. grpcio takes an eternity to build for example
also apparently alpine/musl images have DNS resolution problems
this uses an official "slim" python image based on debian stable. from a quick glance at uncompressed image sizes on my local machine, this is actually 300mb smaller:
i have not rigorously tested this but it seems okay
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.