feat: Configure multi apps per task per owner #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
force-pushed
the
gio/multi-apps/task-app-name-config
branch
from
cdbceb6
to
602dbb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 414 416 +2
Lines 32764 32819 +55
=======================================
+ Hits 32142 32197 +55
Misses 622 622
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
force-pushed
the
gio/multi-apps/task-app-name-config
branch
5 times, most recently
from
4926bf7
to
f33fcd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 383 385 +2
Lines 32063 32118 +55
=======================================
+ Hits 31445 31500 +55
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 383 385 +2
Lines 32063 32118 +55
=======================================
+ Hits 31445 31500 +55
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Allows for owners to define configuration of what app to use for a specific task. Owners can have multiple apps with the same name that are considered for the task, as long as they are configured properly. The catch here is that currently there's no way to configure these apps unless you do it manually. We will use that for testing.
giovanni-guidini
force-pushed
the
gio/multi-apps/task-app-name-config
branch
from
f33fcd7
to
340e32f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage ? 98.14%
=======================================
Files ? 385
Lines ? 32100
Branches ? 0
=======================================
Hits ? 31504
Misses ? 596
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Depends on codecov/codecov-api#421 |
matt-codecov
approved these changes
Mar 4, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for owners to define configuration of what app
to use for a specific task. Owners can have multiple apps
with the same name that are considered for the task,
as long as they are configured properly.
The catch here is that currently there's no way to configure
these apps unless you do it manually. We will use that for testing.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.