-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle scientific notation when parsing hit count in lcov reports #227
Conversation
Codecov ReportAttention: @@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 98.22% 98.22% -0.01%
==========================================
Files 369 369
Lines 29808 29813 +5
==========================================
+ Hits 29279 29283 +4
- Misses 529 530 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 98.22% 98.22% -0.01%
==========================================
Files 369 369
Lines 29808 29813 +5
==========================================
+ Hits 29279 29283 +4
- Misses 529 530 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 98.22% 98.22% -0.01%
==========================================
Files 369 369
Lines 29808 29813 +5
==========================================
+ Hits 29279 29283 +4
- Misses 529 530 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 98.19% 98.19% -0.01%
==========================================
Files 400 400
Lines 30509 30514 +5
==========================================
+ Hits 29959 29963 +4
- Misses 550 551 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
surprisingly, we encountered a report where a line was executed >2**64 times and the lcov tool emitted the hit count with scientific notation. this commit handles that
i mocked up lcov data that uses scientific notation and ran the upload through my local instance of codecov and it worked: https://github.com/matt-codecov/test-lcov-sci-notation
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.