fix: Handle removed bundles in PR comment #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-codecov
requested review from
adrian-codecov,
giovanni-guidini and
joseph-sentry
adrian-codecov
approved these changes
Dec 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 369 369
Lines 29806 29808 +2
=======================================
+ Hits 29277 29279 +2
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 369 369
Lines 29806 29808 +2
=======================================
+ Hits 29277 29279 +2
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 369 369
Lines 29806 29808 +2
=======================================
+ Hits 29277 29279 +2
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 400 400
Lines 30507 30509 +2
=======================================
+ Hits 29957 29959 +2
Misses 550 550
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
scott-codecov
force-pushed
the
scott/bundle-analysis-comment
branch
from
6988adf
to
b5cd623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code would have errored previously when trying to call
head_bundle_report.total_size()(sincehead_bundle_reportwould have beenNoneif removed)