feat: Bundle analysis notify task #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-codecov
force-pushed
the
scott/bundle-analysis-notify
branch
from
f1eabca
to
c02c10f
Compare
Codecov ReportAttention:
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 98.21% 98.19% -0.02%
==========================================
Files 397 400 +3
Lines 30176 30506 +330
==========================================
+ Hits 29637 29956 +319
- Misses 539 550 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
Codecov ReportAttention: @@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 98.24% 98.22% -0.02%
==========================================
Files 366 369 +3
Lines 29475 29806 +331
==========================================
+ Hits 28957 29277 +320
- Misses 518 529 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 98.24% 98.22% -0.02%
==========================================
Files 366 369 +3
Lines 29475 29806 +331
==========================================
+ Hits 28957 29277 +320
- Misses 518 529 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 98.24% 98.22% -0.02%
==========================================
Files 366 369 +3
Lines 29475 29806 +331
==========================================
+ Hits 28957 29277 +320
- Misses 518 529 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
force-pushed
the
scott/bundle-analysis-notify
branch
2 times, most recently
from
db8546a
to
0472879
Compare
scott-codecov
requested review from
giovanni-guidini,
matt-codecov,
joseph-sentry and
adrian-codecov
joseph-sentry
approved these changes
Dec 28, 2023
scott-codecov
force-pushed
the
scott/bundle-analysis-notify
branch
from
0472879
to
ad8af4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate task for now and results in a separate PR comment. Ideally this would be part of the existing notify task but there's some significant refactoring work that needs to be done first to support that.
This new task runs at the end of the bundle analysis processor chain and posts a PR comment with information regarding the bundle analysis comparison across base/head commits.
Depends on the migration in codecov/codecov-api#320