Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove timeseries timer use from base codecov task #223

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

joseph-sentry
Copy link
Contributor

fixes issues we've been seeing today hopefully

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         366      366              
  Lines       29476    29475       -1     
==========================================
- Hits        28958    28957       -1     
  Misses        518      518              
Flag Coverage Δ
integration ?
latest-uploader-overall 98.24% <ø> (-0.01%) ⬇️
unit 98.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (-0.01%) ⬇️
OutsideTasks 97.95% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 98.46% <ø> (-0.03%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a67e8b1) 98.24% compared to head (43c0aa8) 98.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         366      366              
  Lines       29476    29475       -1     
==========================================
- Hits        28958    28957       -1     
  Misses        518      518              
Flag Coverage Δ
integration ?
latest-uploader-overall 98.24% <ø> (-0.01%) ⬇️
unit 98.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (-0.01%) ⬇️
OutsideTasks 97.95% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 98.46% <ø> (-0.03%) ⬇️

Copy link

codecov-public-qa bot commented Dec 21, 2023

Codecov Report

Merging #223 (43c0aa8) into main (a67e8b1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         366      366              
  Lines       29476    29475       -1     
==========================================
- Hits        28958    28957       -1     
  Misses        518      518              
Flag Coverage Δ
integration 98.24% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.24% <ø> (-0.01%) ⬇️
unit 98.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.48% <ø> (-0.01%) ⬇️
OutsideTasks 97.95% <ø> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 98.46% <ø> (-0.03%) ⬇️

@joseph-sentry joseph-sentry merged commit 8615836 into main Dec 21, 2023
21 of 22 checks passed
@joseph-sentry joseph-sentry deleted the joseph/undo-timeseries-timer branch December 21, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants